Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows maintainers / developers wanted #4466

Open
ThomasWaldmann opened this issue Mar 21, 2019 · 9 comments
Labels

Comments

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Mar 21, 2019

So, who wants to commit to develop, maintain, review windows related code?

There is some code already in master, more code is waiting in "windows" branch.

The main blockers to get more stuff into master are:

  • there need to be (windows) devs reviewing the already existing code before it gets into master
  • there need to be (windows) devs maintaining it in future and managing development of that part of borg - this is a long term thing, not a one time work.
  • stuff must be tested on windows. automated and likely sometimes also manual.
  • either windows branch must be brought into a better and reviewed state so it can be fully merged into master or smaller PRs could be made against master.
  • there should be an extension to our Vagrantfile so we can use vagrant to provision a windows VM for testing / running the tests locally / debugging independent of developer's base OS.

So whoever wants to help, please add a comment below and state how you can help.

@ThomasWaldmann

This comment has been minimized.

Copy link
Member Author

@ThomasWaldmann ThomasWaldmann commented Mar 21, 2019

About myself:

I can help with generic borg advice, but not with anything that requires knowledge of windows / ntfs / win32 api specific stuff.

I can review PRs that are relatively generic / simple, but if it gets too deep into win32 / ntfs, there must be other reviewers.

Also, I rarely use Windows myself, so my personal interests are rather in everything non-windows in borg.

@mrhut10

This comment has been minimized.

Copy link

@mrhut10 mrhut10 commented Mar 21, 2019

I'm happy to test stuff, like person above I don't know win32 api off the to of my head. But would loved to use Borg on windows so please enlist my help to test when you can.

@Anakonda

This comment has been minimized.

Copy link

@Anakonda Anakonda commented Mar 22, 2019

I'm windows dev and happy to help.

@jrast

This comment has been minimized.

Copy link
Contributor

@jrast jrast commented Jul 27, 2019

I started to poke around with windows 10 and borg. You can find my progress in the win10 branch: https://github.com/jrast/borg/tree/win10

I started with the borg master branch (not the windows branch which already had some windows related changes). As I just started the work, there is not much to see... But borg compiles and is installable. A simple borg does not crash.

The goal is to get borg running under windows 10. I track my progress in https://github.com/jrast/borg/blob/win10/README_WINDOWS.rst

@jrast

This comment has been minimized.

Copy link
Contributor

@jrast jrast commented Jul 28, 2019

Is the idea to run borg directly on windows or should cygwin / WSL be used to run borg and just improve the windows specific details? In my opinion WSL is to complex for new users, and even for users who can handle WSL it's not optimal as the backup system lives (more or less) in another system. Cygwin would be an option as all dependencies can be packed together in a single executable or distribution. Running borg on windows without WSL or cygwin is ambitious but would offer the greatest flexibility.

@Anakonda

This comment has been minimized.

Copy link

@Anakonda Anakonda commented Jul 28, 2019

There is already cygwin build i don't know its status.
I understood this would be native build.

@ThomasWaldmann

This comment has been minimized.

Copy link
Member Author

@ThomasWaldmann ThomasWaldmann commented Jul 28, 2019

I tried cygwin now and then and at least the tests mostly worked (building and installing it on cygwin works / feels a lot like on linux). I don't use borg productively for windows though.

Having a native build for windows would make it more interesting for all the people not using cygwin.

@jrast

This comment has been minimized.

Copy link
Contributor

@jrast jrast commented Jul 28, 2019

I'm currently working with the Cygwin build for personal backups. It's working fine so far but building new releases is not as easy as it seems.

A native build would be nice, even if it is a lot of (initial) work. But let's do this!

@ThomasWaldmann

This comment has been minimized.

Copy link
Member Author

@ThomasWaldmann ThomasWaldmann commented Oct 26, 2019

General note: If there are windows-specific issues, please put them into a separate issues.

There is a "os: windows" label for these.

@borgbackup borgbackup deleted a comment from henfri Oct 26, 2019
@borgbackup borgbackup deleted a comment from henfri Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.