Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warnings on repository copies to avoid future problem like #4272 #4285

Merged
merged 3 commits into from Feb 10, 2019

Conversation

Projects
None yet
2 participants
@anarcat
Copy link
Contributor

anarcat commented Jan 30, 2019

fixes #3933.

repository, because Borg is cautious and does not automatically remove
stale locks made by a different host.
Yes, you could just copy all the files. But you generally do not want
to do that.

This comment has been minimized.

@ThomasWaldmann

ThomasWaldmann Jan 30, 2019

Member

well, that is maybe a bit too restrictive.

quite some people e.g. use rclone to have a copy of their local repo in the cloud, just in case their house burns down or so.

This comment has been minimized.

@anarcat

anarcat Jan 30, 2019

Author Contributor

how should i phrase this instead?

This comment has been minimized.

@ThomasWaldmann

ThomasWaldmann Feb 5, 2019

Member

we should mention borg with-lock ... here. it will also produce a lock, but it will use the lock so not other borg updates the repo while it is copied / synchronized.

the problem is not making the copy, but using borg to access more than 1 of the set of original and cloned repos (includes: just reading, updating independently, etc.).

@ThomasWaldmann

This comment has been minimized.

Copy link
Member

ThomasWaldmann commented Feb 10, 2019

@anarcat i improved it myself, have a look.

i chose to refactor it a bit, to make the point more clearer:

  • first, talk about what one should do to have multiple redundant repos
  • talk less about what one should not do anyway (like copying a repo while a backup is running)
  • second, talk about problematic ways to have identical copies of a repo, what the problems are and what one must not do.
@ThomasWaldmann

This comment has been minimized.

Copy link
Member

ThomasWaldmann commented Feb 10, 2019

also changed "repo2" to "copy-of-repo" to avoid people having the impression that this creates another usable repository.

@ThomasWaldmann ThomasWaldmann added this to the 1.1.9 milestone Feb 10, 2019

@ThomasWaldmann

This comment has been minimized.

Copy link
Member

ThomasWaldmann commented Feb 10, 2019

I'll merge it as is, hopefully it is ok for you @anarcat. Want to get 1.1.9 out tonight.

@ThomasWaldmann ThomasWaldmann merged commit 10a4e01 into borgbackup:master Feb 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anarcat anarcat deleted the anarcat:faq branch Feb 10, 2019

@anarcat

This comment has been minimized.

Copy link
Contributor Author

anarcat commented Feb 10, 2019

thanks for taking this the final steps... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.