Skip to content

improve yes tests #9661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasWaldmann merged 1 commit into from
May 22, 2026
+34 −34
Merged

improve yes tests #9661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions src/borg/testsuite/helpers/yes_no_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,30 @@

def test_yes_input():
inputs = list(TRUISH)
input = FakeInputs(inputs)
while input.available():
assert yes(input=input)
fake_input = FakeInputs(inputs)
while fake_input.available():
assert yes(input=fake_input)
inputs = list(FALSISH)
input = FakeInputs(inputs)
while input.available():
assert not yes(input=input)
fake_input = FakeInputs(inputs)
while fake_input.available():
assert not yes(input=fake_input)


def test_yes_input_defaults():
inputs = list(DEFAULTISH)
input = FakeInputs(inputs)
while input.available():
assert yes(default=True, input=input)
input = FakeInputs(inputs)
while input.available():
assert not yes(default=False, input=input)
fake_input = FakeInputs(inputs)
while fake_input.available():
assert yes(default=True, input=fake_input)
fake_input = FakeInputs(inputs)
while fake_input.available():
assert not yes(default=False, input=fake_input)


def test_yes_input_custom():
input = FakeInputs(["YES", "SURE", "NOPE"])
assert yes(truish=("YES",), input=input)
assert yes(truish=("SURE",), input=input)
assert not yes(falsish=("NOPE",), input=input)
fake_input = FakeInputs(["YES", "SURE", "NOPE"])
assert yes(truish=("YES",), input=fake_input)
assert yes(truish=("SURE",), input=fake_input)
assert not yes(falsish=("NOPE",), input=fake_input)


def test_yes_env(monkeypatch):
Expand All @@ -49,26 +49,26 @@ def test_yes_env_default(monkeypatch):


def test_yes_defaults():
input = FakeInputs(["invalid", "", " "])
assert not yes(input=input) # default=False
assert not yes(input=input)
assert not yes(input=input)
input = FakeInputs(["invalid", "", " "])
assert yes(default=True, input=input)
assert yes(default=True, input=input)
assert yes(default=True, input=input)
input = FakeInputs([])
assert yes(default=True, input=input)
assert not yes(default=False, input=input)
fake_input = FakeInputs(["invalid", "", " "])
assert not yes(input=fake_input) # default=False
assert not yes(input=fake_input)
assert not yes(input=fake_input)
fake_input = FakeInputs(["invalid", "", " "])
assert yes(default=True, input=fake_input)
assert yes(default=True, input=fake_input)
assert yes(default=True, input=fake_input)
fake_input = FakeInputs([])
assert yes(default=True, input=fake_input)
assert not yes(default=False, input=fake_input)
with pytest.raises(ValueError):
yes(default=None)


def test_yes_retry():
input = FakeInputs(["foo", "bar", TRUISH[0]])
assert yes(retry_msg="Retry: ", input=input)
input = FakeInputs(["foo", "bar", FALSISH[0]])
assert not yes(retry_msg="Retry: ", input=input)
fake_input = FakeInputs(["foo", "bar", TRUISH[0]])
assert yes(retry_msg="Retry: ", input=fake_input)
fake_input = FakeInputs(["foo", "bar", FALSISH[0]])
assert not yes(retry_msg="Retry: ", input=fake_input)


def test_yes_no_retry():
Expand All @@ -79,14 +79,14 @@ def test_yes_no_retry():


def test_yes_output(capfd):
input = FakeInputs(["invalid", "y", "n"])
assert yes(msg="intro-msg", false_msg="false-msg", true_msg="true-msg", retry_msg="retry-msg", input=input)
fake_input = FakeInputs(["invalid", "y", "n"])
assert yes(msg="intro-msg", false_msg="false-msg", true_msg="true-msg", retry_msg="retry-msg", input=fake_input)
out, err = capfd.readouterr()
assert out == ""
assert "intro-msg" in err
assert "retry-msg" in err
assert "true-msg" in err
assert not yes(msg="intro-msg", false_msg="false-msg", true_msg="true-msg", retry_msg="retry-msg", input=input)
assert not yes(msg="intro-msg", false_msg="false-msg", true_msg="true-msg", retry_msg="retry-msg", input=fake_input)
out, err = capfd.readouterr()
assert out == ""
assert "intro-msg" in err
Expand Down
Loading