Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve password handling #550

Merged
merged 84 commits into from
Jan 18, 2021
Merged

Improve password handling #550

merged 84 commits into from
Jan 18, 2021

Commits on Jul 19, 2020

  1. Improve password handling (partial)

    Add password transparency, remove unneeded variable
    
    Removed variable from password validation
    
    Make confirm box have same properties as password box
    
    Remove prints and add comment
    
    Don't run password transparency in exisitng repo
    
    Remove unneded variable
    
    Seperate password errors from other errors
    
    Use password label, move pass length validation
    
    Undo QT 5 Designer changes
    
    Check for no encryption for pass validation
    
    Remove empty methods, use activated over currentIndexChanged
    
    Lint
    
    Update test
    
    Update tests again
    
    Revert "Lint"
    
    This reverts commit c17d0d8.
    
    Run password validation on click
    
    Fix bad variable name
    
    Update transparency on encryption change
    
    Click save before testing password label
    
    Add 'be'
    
    Set text rather than typing
    
    Make passwords greater than 8 in length
    
    Validate password while typing
    
    Update plaintext warning message
    
    Offer alternatives to plain text password storage
    
    Update plaintext warning message
    
    Clarify that Linux has secret service api and macos has keychain access
    
    Clarify where the passwords will be stored
    
    Lint
    
    Run password transparency in existing repo window, reduce wordiness
    
    Old secret service API message was too long and confusing
    
    Lint
    
    Grammar
    
    Seperate password validation function
    
    For samuel-w/KeyManagement
    
    Lint
    
    lint again
    
    Fix so that label updates on default keyring, break plaintext warning onto 2 lines
    
    Cleanup message setting, add KWallet messages
    
    Lint
    
    Lint
    
    Move password validation to utils
    samuel-w committed Jul 19, 2020
    Configuration menu
    Copy the full SHA
    7af6dad View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Add translation strings

    samuel-w committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    e7dfbd3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    573ecdd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Configuration menu
    Copy the full SHA
    12d054a View commit details
    Browse the repository at this point in the history
  2. Lint

    samuel-w committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    3486d27 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Add memory keyring

    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    58ed4ef View commit details
    Browse the repository at this point in the history
  2. Add methods to keyring

    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    1e750ec View commit details
    Browse the repository at this point in the history
  3. Lint

    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    78d9435 View commit details
    Browse the repository at this point in the history
  4. Prevent circular import

    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    cc62821 View commit details
    Browse the repository at this point in the history
  5. Remove debug print

    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    625fcd6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9fe91f0 View commit details
    Browse the repository at this point in the history
  7. Store passwords statically

    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    a2706f8 View commit details
    Browse the repository at this point in the history
  8. Revert memory keyring changes

    I tried to get it working, if someone
    else wants to try feel free
    
    This reverts commit 58ed4ef.
    samuel-w committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    0b79cee View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2020

  1. Configuration menu
    Copy the full SHA
    1f0d0ce View commit details
    Browse the repository at this point in the history
  2. Remove unneeded function

    samuel-w committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    6aec1e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Configuration menu
    Copy the full SHA
    2c185f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. Configuration menu
    Copy the full SHA
    c2abe80 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2020

  1. Make constants global

    samuel-w committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    3b83b48 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Configuration menu
    Copy the full SHA
    9c59351 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Determine keyring at borg thread

    Fixes password detection failure when starting without keyring program
    open, opening keyring program and then running backup. Vorta goes
    directly to DBKeyring, instead of going down the chain of programs.
    samuel-w committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    c8f5be5 View commit details
    Browse the repository at this point in the history
  2. Seperate import

    samuel-w committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7679df0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2020

  1. Configuration menu
    Copy the full SHA
    55aecef View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Clarify comment

    samuel-w committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b06df6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54713db View commit details
    Browse the repository at this point in the history
  3. Deduplicate string

    samuel-w committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    e22bee7 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Configuration menu
    Copy the full SHA
    184d103 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Configuration menu
    Copy the full SHA
    1728054 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d3e0b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. Configuration menu
    Copy the full SHA
    d8d97d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Configuration menu
    Copy the full SHA
    0fe8447 View commit details
    Browse the repository at this point in the history
  2. Add message for when cannot find password

    Message by @Ramblurr
    samuel-w committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    d132bdf View commit details
    Browse the repository at this point in the history
  3. Fix FakeRepo

    samuel-w committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    66b1b9b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    210240e View commit details
    Browse the repository at this point in the history
  5. Revert "Determine keyring at borg thread"

    This reverts commit c8f5be5.
    samuel-w committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    39526d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Configuration menu
    Copy the full SHA
    bc384fe View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Move import back down

    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    282df94 View commit details
    Browse the repository at this point in the history
  2. Add translation string

    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    02a1112 View commit details
    Browse the repository at this point in the history
  3. Translate directly

    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    2b3a32f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0a8ce63 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    48a763f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc72d9e View commit details
    Browse the repository at this point in the history
  7. Remove accidental paste

    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    6c74ad5 View commit details
    Browse the repository at this point in the history
  8. Revert "Translate directly"

    This reverts commit 2b3a32f.
    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    9eb3426 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c034c56 View commit details
    Browse the repository at this point in the history
  10. Fix missed variable name

    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    01ccfff View commit details
    Browse the repository at this point in the history
  11. Break string across lines

    samuel-w committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    31aa3c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Configuration menu
    Copy the full SHA
    9febacd View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Configuration menu
    Copy the full SHA
    20b3918 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Cleanup transparency

    samuel-w committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    4694050 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29e6e3a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Configuration menu
    Copy the full SHA
    d8a373a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Configuration menu
    Copy the full SHA
    e99d432 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Use fstring

    samuel-w committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    6ba5175 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Revert "Use fstring"

    This reverts commit 6ba5175.
    samuel-w committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    d0d6c0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e124070 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Configuration menu
    Copy the full SHA
    c7b3f1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75adbca View commit details
    Browse the repository at this point in the history
  3. Add password visibility box

    samuel-w committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    6eabeaf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2b8e3d View commit details
    Browse the repository at this point in the history
  5. Punctuation

    samuel-w committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    8a83008 View commit details
    Browse the repository at this point in the history
  6. Fix tests

    samuel-w committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    1831c46 View commit details
    Browse the repository at this point in the history
  7. Don't use entire values

    samuel-w committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    27e844b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    981b584 View commit details
    Browse the repository at this point in the history
  9. Various small changes, squashed below

    Remove old resource
    
    Remove KWallet4 string
    
    Use format
    
    Use bool casting
    
    Delete unused objects
    
    Don't use lambda
    samuel-w committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    ed19950 View commit details
    Browse the repository at this point in the history
  10. Remove lambda

    samuel-w committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    55bb22d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Configuration menu
    Copy the full SHA
    5410497 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Configuration menu
    Copy the full SHA
    2b1bf29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f2c137 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Configuration menu
    Copy the full SHA
    5b9132e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. Configuration menu
    Copy the full SHA
    70c3b1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9425115 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Configuration menu
    Copy the full SHA
    6d8e53e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34f9184 View commit details
    Browse the repository at this point in the history
  3. Fix keyring

    samuel-w committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    0307b90 View commit details
    Browse the repository at this point in the history
  4. Remove unneeded line

    samuel-w committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    3177ec4 View commit details
    Browse the repository at this point in the history
  5. Make tests go brrrrr

    samuel-w committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    f5d151b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Configuration menu
    Copy the full SHA
    aaf2f98 View commit details
    Browse the repository at this point in the history
  2. Add comments

    samuel-w committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    6d7e689 View commit details
    Browse the repository at this point in the history
  3. KWallet 5 -> KWallet

    samuel-w committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    6dfb5ee View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Configuration menu
    Copy the full SHA
    2130543 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Configuration menu
    Copy the full SHA
    c7374e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Configuration menu
    Copy the full SHA
    7d92c35 View commit details
    Browse the repository at this point in the history
  2. Simplify backend detection

    samuel-w committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    183693c View commit details
    Browse the repository at this point in the history
  3. Use snake case

    samuel-w committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    23e1a2a View commit details
    Browse the repository at this point in the history