Permalink
Browse files

Set output alert when failing to parse public key.

Previously, the alert was uninitialised.

(Thanks to Robert Swiecki and honggfuzz.)

Change-Id: I2d4eb96b0126f3eb502672b2600ad43ae140acec
Reviewed-on: https://boringssl-review.googlesource.com/13700
Commit-Queue: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
  • Loading branch information...
agl authored and CQ bot account: commit-bot@chromium.org committed Feb 8, 2017
1 parent cdb6fe9 commit 7dccc71e08105b100c3acd56fa5f6fc1ba9b71d3
Showing with 1 addition and 0 deletions.
  1. +1 −0 ssl/ssl_cert.c
@@ -590,6 +590,7 @@ STACK_OF(CRYPTO_BUFFER) *ssl_parse_cert_chain(uint8_t *out_alert,
if (sk_CRYPTO_BUFFER_num(ret) == 0) {
*out_pubkey = ssl_cert_parse_pubkey(&certificate);
if (*out_pubkey == NULL) {
*out_alert = SSL_AD_DECODE_ERROR;
goto err;
}

0 comments on commit 7dccc71

Please sign in to comment.