Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added phar compiler #20

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

leric commented Apr 3, 2013

added phar compiler

Contributor

d11wtq commented Apr 3, 2013

Doesn't this introduce a dependency on symfony?

leric commented Apr 3, 2013

Just the compile process, code inside the phar doesn't change at all. User can just download a boris.phar, move it to /usr/bin/boris, and done.

run php bin/compile.php , a boris.phar will be generated at pwd

Contributor

d11wtq commented Apr 4, 2013

So would the .phar be checked into git or something or people to download from github?

leric commented Apr 17, 2013

I don't think it belongs to the repo, just a file for download

Contributor

MattKetmo commented Apr 18, 2013

I think you should only add a box.json file to the project root, and use Box to create the phar file.

It's much simplier, you don't need to add dependencies to symfony/file, and don't need to rewrite a compiler script again and again for each projet…

Contributor

d11wtq commented Apr 18, 2013

I've merged the .box version, as that seems much cleaner to me ;) Thanks for the PR anyway.

@d11wtq d11wtq closed this Apr 18, 2013

leric commented Apr 25, 2013

Good to know there's such a good tool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment