Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add geometry.d.ts #4758

Merged
merged 3 commits into from Jul 3, 2015
Merged

add geometry.d.ts #4758

merged 3 commits into from Jul 3, 2015

Conversation

nakakura
Copy link
Contributor

Add Geometry Interfaces Spec

@vvakame
Copy link
Member

vvakame commented Jun 28, 2015

geometry/geometry.d.ts

check list

vvakame
vvakame reviewed Jun 28, 2015
View reviewed changes
npm-debug.log
@@ -0,0 +1,36 @@
0 info it worked if it ends with ok
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file.

@vvakame
Copy link
Member

vvakame commented Jun 28, 2015

geometry is already in npm. but, I do not find a good name...

@nakakura
Copy link
Contributor Author

Thank you for your comment @vvakame san.
I changed the filename to "geometry-dom.d.ts" and removed npm-debug.log.
I searched npm and bower libraries.
There seemed to be no conflict.
I'm sorry to have troubled you

vvakame added a commit that referenced this pull request Jul 3, 2015
@vvakame
Merge pull request #4758 from nakakura/geometry.d.ts
ef5aced 
add geometry.d.ts
@vvakame vvakame merged commit ef5aced into DefinitelyTyped:master Jul 3, 2015
@vvakame
Copy link
Member

vvakame commented Jul 3, 2015

@nakakura さん。thanks mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nakakura @vvakame