-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(bug) (types) Workaround for mas account failing on macOS >= 12... now also include macOS 13 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Warning | |
---|---|
Are you sure we don't need to add/update tests? |
Generated by 🚫 Danger
Generated by 🚫 Danger |
…w also include macOS 13 Addition to borksh#43 Very obviously super hacky... but it's a quick and dirty GOOD ENOUGH for now...
2b50915
to
7970850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Good on 'ya. | |
---|---|
✅ |
Generated by 🚫 Danger
Hah. I'll take it. Let me fix the Ubuntu test workflow and then I'll approve now that Danger is happy. |
|
Sure thing Edit: neat Edit 2: 2 fast 4 u ;) |
Addition to #43
Very obviously super hacky... but it's a quick and dirty GOOD ENOUGH for now...
We experimented with Greater Than Or Equal To stuff in the original PR, but never got it working.
May experiment further at some point... especially as mas-cli/mas#417 appears to be going nowhere fast