New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globs in status and pr-status config directives #539

Closed
notriddle opened this Issue Nov 5, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@notriddle
Copy link
Member

notriddle commented Nov 5, 2018

GitLab CI (when used with GitHub) doesn't always post exactly the same status identifier on every build, either including the builder name or the branch name, neither of which we want to hardcode in the bors.toml file (because the branch is different between staging and trying, and the builder name can vary randomly).

For a good workaround, we should allow the status to have a glob in its name, so that ci/gitlab/* works the same way it would in a bash shell.

For the initial implementation, there's no need to worry about big-O complexity, since few users have more than about five build statuses on a commit.

zealousidealroll added a commit to zealousidealroll/bors-ng that referenced this issue Nov 18, 2018

[feature] Add support for wildcards in status
Fixes bors-ng#539

Is it okay if it uses SQL-syntax for wildcards?
With something like "ci/gitlab/%"?

bors bot added a commit that referenced this issue Nov 19, 2018

Merge #547
547: [feature] Add support for wildcards in status r=notriddle a=zealousidealroll

Fixes #539

Is it okay if it uses SQL-syntax for wildcards?
With something like "ci/gitlab/%"?

Co-authored-by: zealousidealroll <zealousidealroll@protonmail.com>

@bors bors bot closed this in #547 Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment