Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Useless with branch protection #576

Closed
jethrogb opened this issue Jan 9, 2019 · 2 comments
Closed

Useless with branch protection #576

jethrogb opened this issue Jan 9, 2019 · 2 comments

Comments

@jethrogb
Copy link

jethrogb commented Jan 9, 2019

Because of a bug in GitHub this app is useless with branch protection enabled.
@jethrogb
Copy link
Author

jethrogb commented Jan 9, 2019 •
edited
Loading

The GitHub UI is not at all clear about this, but I suppose this is the recommended branch protection configuration for use with bors:
image

Note that the requirement “Require status checks to pass before merging” doesn't appear to have anything to do with merging, it applies to all forms of modifying the branch.

@notriddle
Copy link
Member

Yeah, that's the recommendes setup.

@jethrogb jethrogb mentioned this issue May 7, 2019
Closed
@jethrogb jethrogb mentioned this issue Mar 2, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jethrogb @notriddle