This repository was archived by the owner on Apr 4, 2024. It is now read-only.
fix(syncer): Reference correct GitHub.User key for id.#1666
Merged
Conversation
The `:user_xref` key doesn't exist on `BorsNG.GitHub.User`s. Rather it looks like this code should have been trying to access the plain `:id` key instead. This should fix #1665
notriddle
approved these changes
May 30, 2023
notriddle
left a comment
notriddle
left a comment
Member
There was a problem hiding this comment.
bors r+
Thanks for finding this!
Contributor
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
notriddle
added a commit
to bors-ng/bors-ng.github.io
that referenced
this pull request
Jun 1, 2023
Add @nairb774 to new contributors list Add bors-ng/bors-ng#1666 Add bors-ng/bors-ng#1645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:user_xrefkey doesn't exist onBorsNG.GitHub.Users. Rather it looks like this code should have been trying to access the plain:idkey instead.This should fix #1665