This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Fix get_statuses_!
to handle non-200 status codes
#1683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the exact same fix as:
#1260
… except for
get_statuses_!
instead ofget_checks_!
To provide some context (for both fixes), this is necessary in order to gracefully handle non-200 status codes. Before this fix the non-200 code path would set
raw
to an empty list, and fail with:… because it's trying to evaluate
[]["statuses"]
. The fix is forraw
to be an object of the correct shape so that the access succeeds.