This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Fix sync_patch's use of draft field
#1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The map returned by `Jason.decode` uses strings for keys and not atoms:
```elixir
>>> {:ok, json} = Jason.decode(~s({ "draft": true }))
{:ok, %{"draft" => true}}
>>> json
%{"draft" => true}
```
… which meant that `pr[:draft]` would always return `nil` and so
`bors-ng` would never detect that a PR was in the draft state:
```elixir
>>> json[:draft]
nil
>>> json["draft"]
true
```
The fix is to check for `pr["draft"]`, which fixes the problem.
This wasn't caught by the tests because the tests create a map with
atom keys, which didn't trigger this problem.
notriddle
approved these changes
Jun 22, 2023
notriddle
added a commit
to bors-ng/bors-ng.github.io
that referenced
this pull request
Jul 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map returned by
Jason.decodeuses strings for keys and not atoms:… which meant that
pr[:draft]would always returnniland sobors-ngwould never detect that a PR was in the draft state:The fix is to check for
pr["draft"], which fixes the problem.This wasn't caught by the tests because the tests create a map with atom keys, which didn't trigger this problem.