New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend support for automatic reviewer/member assignment per-repository #360

Merged
merged 1 commit into from Mar 12, 2018

Conversation

Projects
None yet
2 participants
@danielkza
Contributor

danielkza commented Mar 11, 2018

Instead of just synchronizing repository admins as reviewers, add a
per-project setting indicating which kind of GitHub collaborators
automatically become reviewers or members. Additionally, remove any
user which no longer has the required permissions from the corresponding
user set.

The possible values for the auto_reviewer_required_perm and
auto_member_required_perm are admin, push and pull, matching the
GitHub permission model, or nil, indicating that no automatic
synchronization should be performed.

This will make it easier to manage large repositories/organizations with
many collaborators without requiring manual handling for each repository.

User interface changes exposing those settings to users will be added at
a later pull-request.

@danielkza danielkza force-pushed the danielkza:github-permission-sync-backend branch from a24c5da to 865bac3 Mar 11, 2018

Add backend support for automatic reviewer/member assignment per-repo…
…sitory

Instead of just synchronizing repository admins as reviewers, add a
per-project setting indicating which kind of GitHub collaborators
automatically become reviewers or members. Additionally, remove any
user which no longer has the required permissions from the corresponding
user set.

The possible values for the `auto_reviewer_required_perm` and
`auto_member_required_perm` are `admin`, `push` and `pull`, matching the
GitHub permission model, or `nil`, indicating that no automatic
synchronization should be performed.

This will make it easier to manage large repositories/organizations with
many collaborators without requiring manual handling for each repository.

User interface changes exposing those settings to users will be added at
a later pull-request.

@danielkza danielkza force-pushed the danielkza:github-permission-sync-backend branch from 865bac3 to 4de3c9e Mar 11, 2018

@notriddle

bors r+

bors bot added a commit that referenced this pull request Mar 12, 2018

Merge #360
360: Add backend support for automatic reviewer/member assignment per-repository r=notriddle a=danielkza

Instead of just synchronizing repository admins as reviewers, add a
per-project setting indicating which kind of GitHub collaborators
automatically become reviewers or members. Additionally, remove any
user which no longer has the required permissions from the corresponding
user set.

The possible values for the `auto_reviewer_required_perm` and
`auto_member_required_perm` are `admin`, `push` and `pull`, matching the
GitHub permission model, or `nil`, indicating that no automatic
synchronization should be performed.

This will make it easier to manage large repositories/organizations with
many collaborators without requiring manual handling for each repository.

User interface changes exposing those settings to users will be added at
a later pull-request.
@bors

This comment has been minimized.

Contributor

bors bot commented Mar 12, 2018

@bors bors bot merged commit 4de3c9e into bors-ng:master Mar 12, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

notriddle added a commit to notriddle/bors-ng that referenced this pull request Mar 15, 2018

Do not synchronize reviewers by default
This can be reverted when the GUI for
bors-ng#360 is implemented.

notriddle added a commit to notriddle/bors-ng that referenced this pull request Mar 15, 2018

Do not synchronize reviewers by default
This can be reverted when the GUI for
bors-ng#360 is implemented.

bors bot added a commit that referenced this pull request Mar 15, 2018

Merge #369
369: Do not synchronize reviewers by default r=notriddle a=notriddle

This can be reverted when the GUI for #360 is implemented.

Fixes #368

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Apr 1, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

notriddle added a commit to notriddle/bors-ng that referenced this pull request Apr 24, 2018

bors bot added a commit that referenced this pull request Apr 24, 2018

Merge #411
411: Add a UI for syncing reviewers and members r=notriddle a=notriddle

Fixes #360

Co-authored-by: Michael Howell <michael@notriddle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment