New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to gate on GitHub checks #424

Merged
merged 4 commits into from May 14, 2018

Conversation

Projects
None yet
1 participant
@notriddle
Member

notriddle commented May 11, 2018

Fixes #421

Remove the "staging.tmp" messages
Because we mark the temp commits as `[no ci]`,
and delete the branch immediately afterward,
this code is now dead.

The underlying problem still exists,
but now the error messages are connected to the main commit instead.

@notriddle notriddle force-pushed the notriddle:github-checks-receive branch 3 times, most recently from 960cbb2 to 152944f May 11, 2018

@notriddle notriddle force-pushed the notriddle:github-checks-receive branch from 152944f to 8d00bb9 May 11, 2018

@notriddle

This comment has been minimized.

Member

notriddle commented May 14, 2018

bors r+

@bors

This comment has been minimized.

Contributor

bors bot commented May 14, 2018

👎 Rejected by PR status

@notriddle notriddle force-pushed the notriddle:github-checks-receive branch from 4fffc7c to 12bc545 May 14, 2018

@notriddle

This comment has been minimized.

Member

notriddle commented May 14, 2018

bors r+

bors bot added a commit that referenced this pull request May 14, 2018

Merge #424
424: Allow the user to gate on GitHub checks r=notriddle a=notriddle

Fixes #421 

Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Contributor

bors bot commented May 14, 2018

@bors bors bot merged commit 12bc545 into bors-ng:master May 14, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notriddle notriddle deleted the notriddle:github-checks-receive branch May 14, 2018

@kennytm kennytm referenced this pull request May 15, 2018

Open

Migrate Travis to GitHub Apps #15

0 of 14 tasks complete

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment