Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetBorsToml: Detect .appveyor.yml files #433

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
2 participants
@nbraud
Copy link
Contributor

nbraud commented Jun 20, 2018

Close #366

@notriddle
Copy link
Member

notriddle left a comment

The style checker thinks a few lines are too long.

== test/attemptor_test.exs ==
100: LineLength: Line length should not exceed 80 chars (was 99).
104: LineLength: Line length should not exceed 80 chars (was 82).

Other than that, it looks good to me.

@nbraud

This comment has been minimized.

Copy link
Contributor Author

nbraud commented Jun 22, 2018

Sorry for not getting around to fixing the CI failure earlier; I will see if I can push from here (very spotty connectivity)

@nbraud nbraud force-pushed the nbraud:dot-appveyor branch from b4fbcf5 to 1829922 Jun 22, 2018

@notriddle
Copy link
Member

notriddle left a comment

bors r+

bors bot added a commit that referenced this pull request Jun 22, 2018

Merge #433
433: GetBorsToml: Detect .appveyor.yml files r=notriddle a=nbraud

Close #366

Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jun 22, 2018

@bors bors bot merged commit 1829922 into bors-ng:master Jun 22, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jun 27, 2018

Add bors-ng/bors-ng#433
Add @nbraud as a new contributor

@nbraud nbraud deleted the nbraud:dot-appveyor branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.