New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unwanted space after queue log PR links #438

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
2 participants
@adzenith
Contributor

adzenith commented Jul 26, 2018

Right now the spaces in between PR links in the log are also links, because there's extra whitespace in the a tag here. If we remove that extra whitespace in the a tag, then we should still have a space between links because of the indentation before the a tag giving us our needed whitespace, but it won't be inside the a tag so it won't be part of the link.

This makes the line pretty long; it could also maybe be formatted as e.g.:

<a href="<%= Confex.fetch_env!(:bors, :html_github_root) %>/<%= @project.name %>/pull/<%= patch.pr_xref %>">#<%=
  patch.pr_xref
%></a>
Prevent unwanted space after queue log PR links
Right now the spaces in between PR links in the log are also links, because there's extra whitespace in the `a` tag here. If we remove that extra whitespace in the `a` tag, then we should still have a space between links because of the indentation before the `a` tag giving us our needed whitespace, but it won't be inside the `a` tag so it won't be part of the link.
@notriddle

This comment has been minimized.

Member

notriddle commented Jul 26, 2018

bors r+

bors bot added a commit that referenced this pull request Jul 26, 2018

Merge #438
438: Prevent unwanted space after queue log PR links r=notriddle a=adzenith

Right now the spaces in between PR links in the log are also links, because there's extra whitespace in the `a` tag here. If we remove that extra whitespace in the `a` tag, then we should still have a space between links because of the indentation before the `a` tag giving us our needed whitespace, but it won't be inside the `a` tag so it won't be part of the link.

This makes the line pretty long; it could also maybe be formatted as e.g.:
```
<a href="<%= Confex.fetch_env!(:bors, :html_github_root) %>/<%= @project.name %>/pull/<%= patch.pr_xref %>">#<%=
  patch.pr_xref
%></a>
```

Co-authored-by: Nikolaus Wittenstein <nikolaus.wittenstein@gmail.com>
@bors

This comment has been minimized.

Contributor

bors bot commented Jul 26, 2018

@bors bors bot merged commit 3fc3d47 into bors-ng:master Jul 26, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jul 26, 2018

Add bors-ng/bors-ng#438
Add @adzenith as a new contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment