New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination support for github reviews #444

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@notriddle
Member

notriddle commented Aug 9, 2018

Fixes #437

@notriddle

This comment has been minimized.

Member

notriddle commented Aug 9, 2018

I think this will help, @JensRantil

@notriddle notriddle force-pushed the github-reviews-pagination branch 2 times, most recently from 0012d89 to 81b4418 Aug 9, 2018

@notriddle

This comment has been minimized.

Member

notriddle commented Aug 9, 2018

Okay, here's an example API result with paginated reviews page (specifically, it paginates after 30 results, though I don't want to rely on that).

https://api.github.com/repos/bors-ng-test-org/test-repo-2/pulls/18/reviews

@notriddle notriddle force-pushed the github-reviews-pagination branch from 81b4418 to a2c0a79 Aug 9, 2018

@notriddle

This comment has been minimized.

Member

notriddle commented Aug 9, 2018

bors r+

bors bot added a commit that referenced this pull request Aug 9, 2018

Merge #444
444: Add pagination support for github reviews r=notriddle a=notriddle

Fixes #437

Co-authored-by: Michael Howell <michael@notriddle.com>
@JensRantil

This comment has been minimized.

JensRantil commented Aug 9, 2018

Exciting. I'll give it a spin tomorrow. The PR that was stuck was closed and we reopened the PR and it merging worked. Is there any way I can check if pagination was needed for the closed PR?

@JensRantil

This comment has been minimized.

JensRantil commented Aug 9, 2018

Cc @krlvl

@notriddle

This comment has been minimized.

Member

notriddle commented Aug 9, 2018

@JensRantil Who are you trying to ping? Because @krlvl is not a GitHub account that exists.

@JensRantil

This comment has been minimized.

JensRantil commented Aug 9, 2018

Oops, @krlvi. Thanks!

@bors

This comment has been minimized.

Contributor

bors bot commented Aug 9, 2018

@bors bors bot merged commit a2c0a79 into master Aug 9, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notriddle notriddle deleted the github-reviews-pagination branch Aug 9, 2018

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment