New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "quoted keyword" style warnings on server startup #544

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
2 participants
@alsuren
Contributor

alsuren commented Nov 10, 2018

This is my first elixir PR, so I thought I'd make it something small.

Once I've found my way around the project, I might try to implement something to remember successful builds based on the tree-hash (as suggested here #185 (comment) ). Wish me luck.

The warnings look like this:

  warning: found quoted keyword "sha" but the quotes are not required.
  Note that keywords are always atoms, even when quoted, and quotes
  should only be used to introduce keywords with foreign characters
  in them
    lib/github/github/server.ex:200
Fix quoted keyword style warnings
Warnings look like this:

  warning: found quoted keyword "sha" but the quotes are not required.
  Note that keywords are always atoms, even when quoted, and quotes
  should only be used to introduce keywords with foreign characters
  in them
    lib/github/github/server.ex:200
@notriddle

bors r+

Good luck on the hash checker! 👍

bors bot added a commit that referenced this pull request Nov 10, 2018

Merge #544
544: Fix "quoted keyword" style warnings on server startup r=notriddle a=alsuren

This is my first elixir PR, so I thought I'd make it something small.

Once I've found my way around the project, I might try to implement something to remember successful builds based on the tree-hash (as suggested here #185 (comment) ). Wish me luck.

The warnings look like this:
```
  warning: found quoted keyword "sha" but the quotes are not required.
  Note that keywords are always atoms, even when quoted, and quotes
  should only be used to introduce keywords with foreign characters
  in them
    lib/github/github/server.ex:200
```

Co-authored-by: David Laban <alsuren@gmail.com>
@bors

This comment has been minimized.

Contributor

bors bot commented Nov 10, 2018

Build succeeded

@bors bors bot merged commit 591550a into bors-ng:master Nov 10, 2018

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Nov 19, 2018

Add bors-ng/bors-ng#544
Add @alsuren as new contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment