New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue up attempts rather than running them all at once #582

Merged
merged 5 commits into from Jan 25, 2019

Conversation

Projects
None yet
2 participants

notriddle added some commits Jan 25, 2019

Add white fill to the bors eye in the page logotype
This isn't needed in the web interface currently, but
it makes a more generally-usable logo, and is present
in the plain icon.
Pull in patch for each attempt
Avoids association-not-loaded errors.

@notriddle notriddle force-pushed the notriddle:try-build-nastiness branch from 0a7fc19 to 932448f Jan 25, 2019

@notriddle

This comment has been minimized.

Copy link
Member Author

notriddle commented Jan 25, 2019

bors r+

bors bot added a commit that referenced this pull request Jan 25, 2019

Merge #582
582: Queue up attempts rather than running them all at once r=notriddle a=notriddle

https://forum.bors.tech/t/bors-try-doesnt-wait-untill-last-build-finishes/272

#434 (comment)


Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 25, 2019

Build succeeded

@bors bors bot merged commit 932448f into bors-ng:master Jan 25, 2019

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details

@notriddle notriddle deleted the notriddle:try-build-nastiness branch Jan 25, 2019

@andschwa

This comment has been minimized.

Copy link

andschwa commented Jan 25, 2019

Thank you so much @notriddle!

(Also you asked on the forum why people might be using bors try instead of CI auto-building PRs. In my case, we have two reasons: (1) we don't want to auto-build PRs from just anyone, so bors try gives us a bit of an authentication layer, and (2) if we built every PR whenever they're opened/updated our CI would be so bogged down it would be useless.)

@notriddle

This comment has been minimized.

Copy link
Member Author

notriddle commented Jan 25, 2019

No problem.

(Could your copy your reply over to the forum, so that other participants would be able to see it?)

@andschwa

This comment has been minimized.

Copy link

andschwa commented Jan 25, 2019

Thank you! I don't have account there yet 😄

@notriddle

This comment has been minimized.

Copy link
Member Author

notriddle commented Jan 26, 2019

Don't need one. Just use your GitHub account.

@andschwa

This comment has been minimized.

Copy link

andschwa commented Jan 26, 2019

login

new

🤷‍♂️

@notriddle

This comment has been minimized.

Copy link
Member Author

notriddle commented Jan 26, 2019

You're using Fanboy's Social Blocking List, or something else with the same policy, which blocks any div with the class name "btn-social". This includes the GitHub log in button in Discourse.

@andschwa

This comment has been minimized.

Copy link

andschwa commented Jan 26, 2019

Ah, that is true! I totally forgot about that. Good to know. Thanks again 😄

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Feb 1, 2019

Add bors-ng/bors-ng#582
Add total PR count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment