New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Erlang httpc and Tesla instead of Hackney and HTTPoison #586

Merged
merged 3 commits into from Feb 6, 2019

Conversation

Projects
None yet
1 participant
@notriddle
Copy link
Member

notriddle commented Jan 29, 2019

See the discussion here on the Elixir forums about reliable HTTP libraries.

And see this thread on the Bors forum about intermittent timeouts in the stock distribution.

@notriddle notriddle force-pushed the tesla-http branch 2 times, most recently from 65d4aa6 to 5191126 Jan 29, 2019

notriddle added some commits Jan 29, 2019

Swap out HTTPoison for Tesla
The advantage: Tesla has decent support for retrying,
or for using httpc instead of hackney.

@notriddle notriddle force-pushed the tesla-http branch from d15817a to ae5882c Jan 29, 2019

@notriddle

This comment has been minimized.

Copy link
Member Author

notriddle commented Feb 6, 2019

bors r+

bors bot added a commit that referenced this pull request Feb 6, 2019

Merge #586
586: Switch to using Erlang httpc and Tesla instead of Hackney and HTTPoison r=notriddle a=notriddle

See the discussion [here on the Elixir forums](https://elixirforum.com/t/reliable-http-libraries-httpoison-httpotion-tesla/12723/10?u=notriddle) about reliable HTTP libraries.

And see [this thread on the Bors forum](https://forum.bors.tech/t/miscellaneous-crashes-put-queue-into-bad-state/275?u=notriddle) about intermittent timeouts in the stock distribution.

Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Feb 6, 2019

Build succeeded

@bors bors bot merged commit ae5882c into master Feb 6, 2019

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
bors Build succeeded
Details

@notriddle notriddle deleted the tesla-http branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment