Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating message when review is already running #590

Merged
merged 3 commits into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@mimimalizam
Copy link
Contributor

commented Feb 3, 2019

This PR replaces message Not awaiting review with Already running a review for Atemptor and Batcher messages when another review is in progress. It should resolve #568. Please let me know if there is anything else left to be changed. Also if suggested Batcher change is excess, I can remove it :) .

@mimimalizam mimimalizam changed the title wip: Updating message when review is already running Updating message when review is already running Feb 3, 2019

@notriddle
Copy link
Member

left a comment

Seems fine up me. Thanks!

bors r+

bors bot added a commit that referenced this pull request Feb 3, 2019

Merge #590
590: Updating message when review is already running r=notriddle a=mimimalizam

This PR replaces message `Not awaiting review` with `Already running a review` for Atemptor and Batcher messages when another review is in progress. It should resolve #568. Please let me know if there is anything else left to be changed. Also if suggested Batcher change is excess, I can remove it :) .  

Co-authored-by: Milana <milana.stojadinov@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2019

Build succeeded

@bors bors bot merged commit 2369ecf into bors-ng:master Feb 3, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details

@mimimalizam mimimalizam deleted the mimimalizam:update-already-running branch Feb 3, 2019

@mimimalizam

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

tnx @notriddle!

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Feb 3, 2019

Add bors-ng/bors-ng#590
Add @mimimalizam as new contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.