Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct phoenix task #655

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@umamaistempo
Copy link
Contributor

commented Jun 5, 2019

The mix.exs of this project requires phoenix to be "~> 1.4.3". Phoenix on v1.3.0 changed the task name from phoenix.server to phx.server; as such, files from the folder /scripts/* that refered to the former name do not work.

This pr simply replace the command phoenix.server to phx.server to make it work as expected

@notriddle
Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Jun 5, 2019

Merge #655
655: Correct phoenix task r=notriddle a=umamaistempo

The `mix.exs` of this project requires phoenix to be `"~> 1.4.3"`. Phoenix on v1.3.0 changed the task name from `phoenix.server` to `phx.server`; as such, files from the folder `/scripts/*` that refered to the former name do not work.

This pr simply replace the command `phoenix.server` to `phx.server` to make it work as expected

Co-authored-by: Charlotte Lorelei de Oliveira <11341349+umamaistempo@users.noreply.github.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Build succeeded

@bors bors bot merged commit 263ed29 into bors-ng:master Jun 5, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.