Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Make merge fail explicitly when an approved PR also has changes requested #656
Currently here at Tink AB, frequently the following situation happens:
This is also correlated to #561
This PR aims to solve this problem by getting bors to explicitly refuse (providing message) when a merge is requested but there are changes requested.
Some minor types were added (as I was using them to explore the code to find out where the problem was). They can be merged as I intend to provide more typespecs in following PRs
This semantics seems strange TBH. I'll keep them working but I believe that the possible branchs should be
So a 0 approval, 1 disapproval when approvals are not required does not seem to make sense in the usual case
notriddle left a comment
I have a couple of questions and comments, but the code looks good.
The goal of this feature, as you've hopefully intuited, is to duplicate the behavior of GitHub Branch Protection. Making it follow GitHub's own behavior more closely is considered a bugfix.