Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not repeat projects on Dashboard when simultaneously Member and Reviewer #659

Merged
merged 2 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@umamaistempo
Copy link
Contributor

commented Jun 7, 2019

Closes #657

@umamaistempo

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Ops, thought we were PgSQL exclusively, but it seems we support MySQL. Will revert last commit then

@umamaistempo umamaistempo force-pushed the umamaistempo:i-657-dedup-project-list branch from 1fbdbe6 to 75a0e9a Jun 7, 2019

@notriddle
Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Jun 7, 2019

Merge #659
659: Do not repeat projects on Dashboard when simultaneously Member and Reviewer r=notriddle a=umamaistempo

Closes #657 

Co-authored-by: Charlotte Lorelei de Oliveira <11341349+umamaistempo@users.noreply.github.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Build succeeded

@bors bors bot merged commit 75a0e9a into bors-ng:master Jun 7, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details

bors bot added a commit that referenced this pull request Jun 11, 2019

Merge #664
664: Sort repositories on Dashboard by name r=notriddle a=umamaistempo

Closes #663

Decided to consolidate it using a `group_by`, this reduces the amount of data returned from DB, the amount of handshakes and the cost of enumerating it, while, in the meantime, the DB can optimize the resultset :>

Might add later some test to check this expectation (ie: add 3 projects, set as reviewer and member of them - in one of them, both - and check that the resultset is the expected)

Edit: Note that on #659 the `order_by: p.repo_xref` was added to ensure that the repo list is consistent (there is no implicit guarantee on ordering for RDBMS without an explicit ordering request). Since we need an order, as mentioned on #663, sorting alphabetically is what would be most helpful for our users as it's easier to find what you expect

Edit2: Thinking about this, it would also probably be a good addition to order the ProjectController.show/4 results. I think that ordering it by `patch.pr_xref DESC` would be the most useful ordering. What do you think ?

Co-authored-by: Charlotte Lorelei de Oliveira <11341349+umamaistempo@users.noreply.github.com>

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.