Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode github URIs to avoid bad request #660

Merged
merged 2 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@umamaistempo
Copy link
Contributor

commented Jun 7, 2019

Closes #626

@umamaistempo umamaistempo changed the title URI Encode github login name to avoid bad request URI Encode github URIs to avoid bad request Jun 7, 2019

@umamaistempo umamaistempo changed the title URI Encode github URIs to avoid bad request Encode github URIs to avoid bad request Jun 7, 2019

@notriddle
Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Jun 10, 2019

Merge #660
660: Encode github URIs to avoid bad request r=notriddle a=umamaistempo

Closes #626

Co-authored-by: Charlotte Lorelei de Oliveira <11341349+umamaistempo@users.noreply.github.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Build succeeded

@bors bors bot merged commit 4f93d99 into bors-ng:master Jun 10, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jul 1, 2019

bors bot added a commit that referenced this pull request Jul 8, 2019

Merge #669
669: Bump credo from 1.0.5 to 1.1.0 r=notriddle a=dependabot-preview[bot]

Bumps [credo](https://github.com/rrrene/credo) from 1.0.5 to 1.1.0.
<details>
<summary>Changelog</summary>

*Sourced from [credo's changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md).*

> ## 1.1.0
> 
> - Credo now requires Elixir 1.5 and Erlang/OTP 19
> - Fix false negative in `DuplicatedCode`
> - `PipeChainStart` has been made opt-in
> 
> ### Plugin Support
> 
> Credo now supports plugins that run alongside Credo's own analysis. While Credo provided the ability to write custom checks since `v0.4.0`, users can now access the complete toolset of Credo to create their own commands, require compilation, run external tools and still include the results in Credo's standard report.
> 
> Please refer to Credo's [README](https://github.com/rrrene/credo#plugins) as well as the [Credo Demo Plugin](https://github.com/rrrene/credo_demo_plugin) for further information on how to get started.
> 
> ### New checks
> 
> - Credo.Check.Refactor.WithClauses
</details>
<details>
<summary>Commits</summary>

- [`479771a`](rrrene/credo@479771a) Bump version to 1.1.0
- [`7ca3ca1`](rrrene/credo@7ca3ca1) Update CAHNGELOG
- [`0b574f4`](rrrene/credo@0b574f4) Update .travis.yml
- [`bc7aa56`](rrrene/credo@bc7aa56) Update travis config
- [`95c956d`](rrrene/credo@95c956d) Format file causing format check to fail on 1.6
- [`a3adf2a`](rrrene/credo@a3adf2a) Reset default config for PipeChainStart
- [`6b7db32`](rrrene/credo@6b7db32) Fix [#660](https://github-redirect.dependabot.com/rrrene/credo/issues/660)
- [`0033038`](rrrene/credo@0033038) Add test reproducing [#660](https://github-redirect.dependabot.com/rrrene/credo/issues/660)
- [`b26d6b5`](rrrene/credo@b26d6b5) Add filenames to replace_with_spaces calls
- [`0bb6b64`](rrrene/credo@0bb6b64) Bump version to 1.1.0-rc3
- Additional commits viewable in [compare view](rrrene/credo@v1.0.5...v1.1.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=credo&package-manager=hex&previous-version=1.0.5&new-version=1.1.0)](https://dependabot.com/compatibility-score.html?dependency-name=credo&package-manager=hex&previous-version=1.0.5&new-version=1.1.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot-preview[bot] <dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.