Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to Database modules #666

Merged
merged 6 commits into from Aug 21, 2019

Conversation

@umamaistempo
Copy link
Contributor

commented Jun 14, 2019

  • Batch
  • Patch
  • Project
  • Attempt
  • AttemptStatus
  • Crash
  • Installation
  • LinkMemberProject
  • LinkPatchBatch
  • LinkUserProject
  • Status
  • User
  • UserPatchDelegation

@umamaistempo umamaistempo force-pushed the umamaistempo:tipefy-types-with-dialyzer branch from 27999b9 to 7156181 Aug 11, 2019

@notriddle

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Hey, @umamaistempo,

Is it okay if I merge this PR as it is? The modules where you've already added types seem pretty good, and I'd like to get these now in case someone else changes these files later and makes a merge conflict.

@umamaistempo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Hey there @notriddle

Sure, let me just commit the changes that I have on my local worktree on my home's personal computer :)

@umamaistempo umamaistempo marked this pull request as ready for review Aug 21, 2019

@umamaistempo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@notriddle feel free to merge it

@umamaistempo umamaistempo self-assigned this Aug 21, 2019

@notriddle
Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Aug 21, 2019
Merge #666
666: Add types to Database modules r=notriddle a=umamaistempo

- [x] Batch
- [x] Patch
- [x] Project
- [x] Attempt
- [x] AttemptStatus
- [x] Crash
- [ ] Installation
- [ ] LinkMemberProject
- [ ] LinkPatchBatch
- [ ] LinkUserProject
- [ ] Status
- [ ] User
- [ ] UserPatchDelegation 

Co-authored-by: Charlotte Lorelei de Oliveira <11341349+umamaistempo@users.noreply.github.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Build failed

  • continuous-integration/travis-ci/push
@notriddle

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Intermittent failure.

bors retry

bors bot added a commit that referenced this pull request Aug 21, 2019
Merge #666
666: Add types to Database modules r=notriddle a=umamaistempo

- [x] Batch
- [x] Patch
- [x] Project
- [x] Attempt
- [x] AttemptStatus
- [x] Crash
- [ ] Installation
- [ ] LinkMemberProject
- [ ] LinkPatchBatch
- [ ] LinkUserProject
- [ ] Status
- [ ] User
- [ ] UserPatchDelegation 

Co-authored-by: Charlotte Lorelei de Oliveira <11341349+umamaistempo@users.noreply.github.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Build succeeded

@bors bors bot merged commit b08016a into bors-ng:master Aug 21, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.