Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error body upon failed push to GitHub #700

Merged

Conversation

@swist
Copy link
Contributor

commented Jul 11, 2019

We were experiencing strange 422 errors when bors was trying to merge
a successful speculative merge. It was failing because of misconfigured
branch protection. Returning the body would trigger the :badmatch
exception with the error message

Return error body upon failed push to GitHub
We were experiencing strange 422 errors when bors was trying to merge
a successful speculative merge. It was failing because of misconfigured
branch protection. Returning the body would trigger the :badmatch
exception with the error message
@notriddle
Copy link
Member

left a comment

Sure, sounds fine to me.

bors r+

bors bot added a commit that referenced this pull request Jul 11, 2019

Merge #700
700: Return error body upon failed push to GitHub r=notriddle a=swist

We were experiencing strange 422 errors when bors was trying to merge
a successful speculative merge. It was failing because of misconfigured
branch protection. Returning the body would trigger the :badmatch
exception with the error message



Co-authored-by: swist <me@swistofon.pl>
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Build succeeded

@bors bors bot merged commit 27d73f0 into bors-ng:master Jul 11, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Aug 1, 2019

Add bors-ng/bors-ng#700
Add @swist as new contributor
@DilumAluthge

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

I just wanted to say thank you to @swist and @notriddle for this patch! It has been tremendously helpful to me in understanding the causes of my 422 errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.