Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and use CODEOWNER #725

Merged
merged 17 commits into from Sep 12, 2019

Conversation

@MarkSRobinson
Copy link
Contributor

commented Aug 9, 2019

lib/github/github.ex Outdated Show resolved Hide resolved
lib/github/github.ex Outdated Show resolved Hide resolved
lib/github/github.ex Outdated Show resolved Hide resolved
lib/github/github/file.ex Outdated Show resolved Hide resolved
lib/github/github/file.ex Outdated Show resolved Hide resolved
lib/github/github/file.ex Outdated Show resolved Hide resolved
lib/github/github/server.ex Outdated Show resolved Hide resolved
lib/github/parse_owner.ex Outdated Show resolved Hide resolved
lib/worker/batcher.ex Outdated Show resolved Hide resolved
lib/worker/batcher.ex Outdated Show resolved Hide resolved
@MarkSRobinson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@notriddle and @umamaistempo

Thanks for the feedback. I'll mark off completed requests with a ⚡️ sign as a I go.

@MarkSRobinson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@notriddle and @umamaistempo

I've added the change you have suggested.

@notriddle

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@MarkSRobinson How's the progress on this going. The RFC is approved, and all our issues have been resolved. It still has the [wip] label on it, though. Would you say it's ready to take it off? Or is there something else holding us up?

@MarkSRobinson MarkSRobinson changed the title [WIP] Parse and use CODEOWNER Parse and use CODEOWNER Sep 12, 2019
@MarkSRobinson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@notriddle Thanks for reminding me. It's ready to land.

Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Sep 12, 2019
Merge #725
725: Parse and use CODEOWNER r=notriddle a=MarkSRobinson

Implementation of RFC: https://forum.bors.tech/t/bors-support-for-codeowners/357

Co-authored-by: Mark Robinson <mrobinson@plaid.com>
Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

Build succeeded

@bors bors bot merged commit f0e1cc6 into bors-ng:master Sep 12, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Sep 15, 2019
bors bot added a commit that referenced this pull request Sep 23, 2019
Merge #753
753: Adding support for asterisk on CodeOwners r=notriddle a=gmendonca

Follow up from #725

There were some logic missing for CodeOwners check, namely:
- Global fallback with `*`
- Two consecutive asterisks `**` in patterns matched against full pathname

I did a super simple approach, not sure if it's the best one. Feedbacks appreciated.

Co-authored-by: Gustavo Mendonca <gustavogmend@gmail.com>
bors bot added a commit that referenced this pull request Sep 23, 2019
Merge #753
753: Adding support for asterisk on CodeOwners r=notriddle a=gmendonca

Follow up from #725

There were some logic missing for CodeOwners check, namely:
- Global fallback with `*`
- Two consecutive asterisks `**` in patterns matched against full pathname

I did a super simple approach, not sure if it's the best one. Feedbacks appreciated.

Co-authored-by: Gustavo Mendonca <gustavogmend@gmail.com>
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Oct 1, 2019
Add @MarkSRobinson as a first-time contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.