Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate: allow abbreviation to d #727

Merged
merged 2 commits into from Sep 20, 2019

Conversation

@tommilligan
Copy link
Contributor

commented Aug 18, 2019

Closes #615.

Add the new commands:

  • d+ (alias of delegate+)
  • d= (alias of delegate=)

Add one new dev/test dependency, ex_parameterized.

@tommilligan tommilligan referenced this pull request Aug 18, 2019
@notriddle

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Okay, I've asked for some feedback on the forum. If nobody says anything in a couple weeks, we'll probably merge it.

Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Sep 20, 2019
Merge #727
727: delegate: allow abbreviation to d r=notriddle a=tommilligan

Closes #615.

Add the new commands:
- `d+` (alias of `delegate+`)
- `d=` (alias of `delegate=`)

Add one new dev/test dependency, [`ex_parameterized`](https://github.com/KazuCocoa/ex_parameterized).

Co-authored-by: Tom Milligan <tommilligan@users.noreply.github.com>
Co-authored-by: Michael Howell <michael@notriddle.com>
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Sep 20, 2019
Implemented by bors-ng/bors-ng#727

Thanks for contributing, @tommilligan
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Build succeeded

@bors bors bot merged commit b8d6d3a into bors-ng:master Sep 20, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
@tommilligan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

Thanks @notriddle for getting this merged 👍

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Oct 1, 2019
Add @tommilligan as first-time contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.