Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include child team members in collaborators #729

Merged
merged 2 commits into from Aug 22, 2019

Conversation

@indirect
Copy link
Contributor

commented Aug 21, 2019

So I'm running into a problem where Bors sync isn't showing collaborators that I would be expecting it to show. The deciding factor seems to be that this organization is very into nested teams, and anyone who is in the top-level team shows up, but anyone in a nested team does not show up. That plus GitHub's Collaborator API docs lead me to believe that Bors needs to use the hellcat-preview content type to get nested team members when syncing collaborators.

Anyone else run into this? Concerns, other thoughts?

indirect added 2 commits Aug 21, 2019
Include child team members in collaborators
GitHub's Nested Teams feature makes it possible to put teams inside
other teams. The regular v3 API does not include child team members when
listing collaborators, which leads to missing permissions when Bors runs
a reviewer sync.

As described in the [Collaborator API docs][1], setting the
`hellcat-preview` content type will cause the API to include members of
child teams when listing contributors.

[1]: https://developer.github.com/v3/repos/collaborators/
@indirect

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

Update: I deployed this to Heroku, it fixes everything for me. 🎉

@notriddle
Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Aug 22, 2019
Merge #729
729: Include child team members in collaborators r=notriddle a=indirect

So I'm running into a problem where Bors sync isn't showing collaborators that I would be expecting it to show. The deciding factor _seems_ to be that this organization is very into nested teams, and anyone who is in the top-level team shows up, but anyone in a tested team does not show up. That plus GitHub's [Collaborator API docs][1] lead me to believe that Bors needs to use the `hellcat-preview` content type to get nested team members when syncing collaborators.

Anyone else run into this? Concerns, other thoughts?

[1]: https://developer.github.com/v3/repos/collaborators/

Co-authored-by: Andre Arko <andre@arko.net>
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Build succeeded

@bors bors bot merged commit f25489d into bors-ng:master Aug 22, 2019

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details

@indirect indirect deleted the indirect:nested-teams-support branch Aug 22, 2019

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.