Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for asterisk on CodeOwners #753

Merged
merged 5 commits into from Sep 23, 2019

Conversation

@gmendonca
Copy link
Contributor

commented Sep 21, 2019

Follow up from #725

There were some logic missing for CodeOwners check, namely:

  • Global fallback with *
  • Two consecutive asterisks ** in patterns matched against full pathname

I did a super simple approach, not sure if it's the best one. Feedbacks appreciated.

gmendonca added 3 commits Sep 21, 2019
lib/github/parse_owner.ex Outdated Show resolved Hide resolved
gmendonca added 2 commits Sep 21, 2019
@gmendonca gmendonca requested a review from notriddle Sep 23, 2019
Copy link
Member

left a comment

bors r+

bors bot added a commit that referenced this pull request Sep 23, 2019
Merge #753
753: Adding support for asterisk on CodeOwners r=notriddle a=gmendonca

Follow up from #725

There were some logic missing for CodeOwners check, namely:
- Global fallback with `*`
- Two consecutive asterisks `**` in patterns matched against full pathname

I did a super simple approach, not sure if it's the best one. Feedbacks appreciated.

Co-authored-by: Gustavo Mendonca <gustavogmend@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Timed out

@notriddle

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 23, 2019
Merge #753
753: Adding support for asterisk on CodeOwners r=notriddle a=gmendonca

Follow up from #725

There were some logic missing for CodeOwners check, namely:
- Global fallback with `*`
- Two consecutive asterisks `**` in patterns matched against full pathname

I did a super simple approach, not sure if it's the best one. Feedbacks appreciated.

Co-authored-by: Gustavo Mendonca <gustavogmend@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 23, 2019

Build succeeded

@bors bors bot merged commit af42844 into bors-ng:master Sep 23, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.