Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitpod.io config files #758

Merged
merged 10 commits into from Sep 30, 2019

Conversation

@notriddle
Copy link
Member

commented Sep 24, 2019

notriddle added 9 commits Sep 24, 2019
since something's broken on their other mirror
We don't need them anyway. The gitpod based image provides them.
It actually makes more sense, since the running command takes over a
terminal panel. We might as well use it.
@umamaistempo

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2019

Nice. Will try to gitpod it locally here and, if it works, LGTM 👍

Edit: managed to bring the workspace up, it was setup and started mix properly. However I was unable to run the test script, it complains about docker not being present, so guess I have to encapsulate that command 🤔

@notriddle

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2019

Yes, you're right, the test script was messed up.

Here's a new commit that fixes it when I tried it.

@notriddle notriddle force-pushed the gitpod-yml branch from 4b3ddd4 to 5f8e3e3 Sep 26, 2019
@notriddle notriddle force-pushed the gitpod-yml branch from 5f8e3e3 to 0c14cad Sep 26, 2019
@notriddle

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 30, 2019
Merge #758
758: Add gitpod.io config files r=notriddle a=notriddle

See https://www.gitpod.io/blog/gitpodify/

Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2019

Build succeeded

@bors bors bot merged commit 0c14cad into master Sep 30, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.