Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing branch deletion when PR is closed when using squash and merge #778

Merged
merged 2 commits into from Oct 21, 2019

Conversation

@gmendonca
Copy link
Contributor

gmendonca commented Oct 18, 2019

Fix #766

gmendonca added 2 commits Oct 18, 2019
pr_squash_merged = String.starts_with?(pr.title, "[Merged by Bors] - ")

if pr_in_same_repo && delete_merged_branches do
cond do

This comment has been minimized.

Copy link
@gmendonca

gmendonca Oct 18, 2019

Author Contributor

Really not sure if it's the best way to do it, seemed more clear to me though.

This comment has been minimized.

Copy link
@notriddle

notriddle Oct 18, 2019

Member

Seems fine to me.

@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Oct 21, 2019

Let's do this, then.

bors r+

bors bot added a commit that referenced this pull request Oct 21, 2019
Merge #778
778: Fixing branch deletion when PR is closed when using squash and merge r=notriddle a=gmendonca

Fix #766

Co-authored-by: Gustavo Mendonca <gustavogmend@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Oct 21, 2019

Build succeeded

@bors bors bot merged commit 4de0435 into bors-ng:master Oct 21, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.