Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format generated commit message #779

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@EFanZh
Copy link
Contributor

EFanZh commented Oct 21, 2019

Subject and body in commit message should be separated with a blank line.

For example, if the title is:

Title

and the body is

Paragraph 1 

Paragraph 2

Then the generated commit message should be:

Title

Paragraph 1 

Paragraph 2

not:

Title
Paragraph 1 

Paragraph 2
Subject and body in commit message should be separated with a blank line.
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Oct 21, 2019

You're right. I'm surprised I messed that up.

bors r+

bors bot added a commit that referenced this pull request Oct 21, 2019
779: Format generated commit message r=notriddle a=EFanZh

Subject and body in commit message should be separated with a blank line.

For example, if the title is:

```
Title
```

and the body is

```
Paragraph 1 

Paragraph 2
```

Then the generated commit message should be:

```
Title

Paragraph 1 

Paragraph 2
```

not:

```
Title
Paragraph 1 

Paragraph 2
```

Co-authored-by: EFanZh <efanzh@gmail.com>
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Oct 21, 2019

Uh, yeah, that's not going to work until #780 merges.

bors r-

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Oct 21, 2019

Canceled

@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Oct 21, 2019

Okay, let's try that again.

bors r+

bors bot added a commit that referenced this pull request Oct 21, 2019
Merge #779
779: Format generated commit message r=notriddle a=EFanZh

Subject and body in commit message should be separated with a blank line.

For example, if the title is:

```
Title
```

and the body is

```
Paragraph 1 

Paragraph 2
```

Then the generated commit message should be:

```
Title

Paragraph 1 

Paragraph 2
```

not:

```
Title
Paragraph 1 

Paragraph 2
```

Co-authored-by: EFanZh <efanzh@gmail.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Oct 21, 2019

Build succeeded

@bors bors bot merged commit 03d6983 into bors-ng:master Oct 21, 2019
3 checks passed
3 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.