Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use destination branch name in squash+merge comment #823

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@ChristianAlexander
Copy link
Contributor

ChristianAlexander commented Dec 13, 2019

This change updates batcher to comment with the name of the branch the merge was performed in, rather than hard-coding # Pull request successfully merged into master..

refactor: produce squash merge message in message.ex
feat: comment correct branch name in squash merge

@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Dec 13, 2019

Ah, yeah, that's a million times better.

bors r+

bors bot added a commit that referenced this pull request Dec 13, 2019
Merge #823
823: Use destination branch name in squash+merge comment r=notriddle a=ChristianAlexander

This change updates batcher to comment with the name of the branch the merge was performed in, rather than hard-coding `# Pull request successfully merged into master.`.

refactor: produce squash merge message in message.ex
feat: comment correct branch name in squash merge

Co-authored-by: Christian Alexander <christian@linux.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 13, 2019

Build succeeded

@bors bors bot merged commit 743d66b into bors-ng:master Dec 13, 2019
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jan 2, 2020
Add @ChristianAlexander as new contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.