Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PR after sending all the comments #832

Merged
merged 2 commits into from Dec 20, 2019

Conversation

@phanle
Copy link
Contributor

phanle commented Dec 20, 2019

Context:
Changing the PR title then adding comments to the PR would trigger email clients like Gmail to think it is a different thread in email notifications.

lib/worker/batcher.ex Outdated Show resolved Hide resolved
@phanle phanle requested a review from notriddle Dec 20, 2019
Copy link
Member

notriddle left a comment

bors r+

bors bot added a commit that referenced this pull request Dec 20, 2019
Merge #832
832: Rename PR after sending all the comments r=notriddle a=phanle

Context: 
Changing the PR title then adding comments to the PR would trigger email clients like Gmail to think it is a different thread in email notifications.

Co-authored-by: Phan Le <phan.le@gusto.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 20, 2019

Build succeeded

@bors bors bot merged commit 0f3c225 into bors-ng:master Dec 20, 2019
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
@phanle phanle deleted the Gusto:pl-rename-pr-after-commenting branch Dec 20, 2019
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jan 2, 2020
Add @phanle as new contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.