Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Batch details page that links from Repository history tab #834

Merged
merged 6 commits into from Dec 28, 2019

Conversation

@noizwaves
Copy link
Contributor

noizwaves commented Dec 24, 2019

Hey, we've been using bors-ng and our developers were having trouble finding the corresponding CI build for their batched PRs. We run a lot concurrent builds, so this can be time consuming and very manual.

In this PR we add a Batch details page, which shows some basic information about the batch, as well as the batch's Status links (if present). This allows a developer to discover their corresponding CI build (buildkite/shipit-test in the attached screenshot).

Basic Batch details page

To get to this page, we added a link from the Repository history tab. We weren't sure of the best way to add this, so we converted the existing "Batch" text into a "Batch X" hyperlink to the details page (see Batch 4 in attached screenshot).

History tab containing link

We have other ideas we'd like your feedback/thoughts on too. Maybe we can update the bors status url we send to the GitHub Status API to point to the new details page (instead of the History page)?

@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Dec 24, 2019

This looks awesome! It's basically perfect right out of the shoot.

In this PR we add a Batch details page, which shows some basic information about the batch, as well as the batch's Status links (if present). This allows a developer to discover their corresponding CI build (buildkite/shipit-test in the attached screenshot).

  • I've left a comment on your template, because there's some info I think you're missing. Overall, it's the right idea.

To get to this page, we added a link from the Repository history tab. We weren't sure of the best way to add this, so we converted the existing "Batch" text into a "Batch X" hyperlink to the details page (see Batch 4 in attached screenshot).

  • That's fine. I would also add a link somewhere on the Pull requests tab, so that we could easily go from the currently running PR to its batch status page, as in <h1><a href="/batches/{n}">Running</a></h1> or something.

We have other ideas we'd like your feedback/thoughts on too. Maybe we can update the bors status url we send to the GitHub Status API to point to the new details page (instead of the History page)?

Sure, as long as the batch status page has all the information as the history line, it's fine.

  • If you're going to do that, add the date to the page. That's the only piece of information in the table that's not in the page.
@ansonlc

This comment has been minimized.

Copy link
Contributor

ansonlc commented Dec 26, 2019

@notriddle thanks for the feedback! I added status state. We can change the status link (also add the date) later in a separate PR.
Happy holidays!

@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Dec 28, 2019

Cool, I'll go ahead and merge this, then.

bors r+

bors bot added a commit that referenced this pull request Dec 28, 2019
Merge #834
834: Add Batch details page that links from Repository history tab r=notriddle a=noizwaves

Hey, we've been using bors-ng and our developers were having trouble finding the corresponding CI build for their batched PRs. We run a lot concurrent builds, so this can be time consuming and very manual.

In this PR we add a Batch details page, which shows some basic information about the batch, as well as the batch's Status links (if present). This allows a developer to discover their corresponding CI build (`buildkite/shipit-test` in the attached screenshot).

<img width="1232" alt="Basic Batch details page" src="https://user-images.githubusercontent.com/1007983/71425956-25232e80-2660-11ea-85f8-a075aaa69f38.png">

To get to this page, we added a link from the Repository history tab. We weren't sure of the best way to add this, so we converted the existing "Batch" text into a "Batch X" hyperlink to the details page (see `Batch 4` in attached screenshot).

<img width="1232" alt="History tab containing link" src="https://user-images.githubusercontent.com/1007983/71425957-25232e80-2660-11ea-8146-baa1c49bbcde.png">

We have other ideas we'd like your feedback/thoughts on too. Maybe we can update the bors status url we send to the GitHub Status API to point to the new details page (instead of the History page)?

Co-authored-by: Chao Lin <linchaoc@gmail.com>
Co-authored-by: Adam Neumann <adam.neumann@gusto.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Dec 28, 2019

Build succeeded

@bors bors bot merged commit f29f98c into bors-ng:master Dec 28, 2019
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
@ansonlc ansonlc deleted the Gusto:cl-add-batch-details-page branch Dec 30, 2019
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Jan 2, 2020
Add @noizwaves as new contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.