Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option for batch size limiting #839

Merged
merged 6 commits into from Feb 26, 2020
Merged

Conversation

@kimsaehun
Copy link
Contributor

kimsaehun commented Jan 2, 2020

Fixes #205

Took a while but I've implemented a 'r+ single on/off' command to have patches be batched by themselves only. However, this only occurs when patches are batched, either during bisect or when a patch is newly reviewed. I couldn't figure out how to make this apply for patches that are already in a running/waiting batch.

Additionally, I wasn't too sure whether ensuring that bisect honors the single patch option was a good idea or not. I'm thinking that it's unnecessary because if a batch fails, the singled patch will either become singled through enough bisections or will successfully merge into master without any issues. I implemented it just in case there was a case I have not thought of but please let me know if it can be removed.

I've added a few test cases to test for the following:

  • patches that are newly reviewed and singled are batched alone and not into existing waiting batches
  • patches that are newly reviewed are not added to batches containing singled patches
  • the bisecting process honors single patches
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Jan 3, 2020

Since this PR adds a new command, it should probably go through an RFC first. Basically, open a topic on the forum, then wait for a month for feedback.

@kimsaehun

This comment has been minimized.

Copy link
Contributor Author

kimsaehun commented Jan 5, 2020

Thanks for the heads up! I wrote one here.

@notriddle notriddle force-pushed the kimsaehun:205 branch from 4866792 to a569491 Feb 26, 2020
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Feb 26, 2020

Rebased onto master and added the standalone single command.

bors r+

bors bot added a commit that referenced this pull request Feb 26, 2020
Merge #839
839: Add a configuration option for batch size limiting r=notriddle a=kimsaehun

Fixes #205 

Took a while but I've implemented a 'r+ single on/off' command to have patches be batched by themselves only. However, this only occurs when patches are batched, either during bisect or when a patch is newly reviewed. I couldn't figure out how to make this apply for patches that are already in a running/waiting batch.

Additionally, I wasn't too sure whether ensuring that bisect honors the single patch option was a good idea or not. I'm thinking that it's unnecessary because if a batch fails, the singled patch will either become singled through enough bisections or will successfully merge into master without any issues. I implemented it just in case there was a case I have not thought of but please let me know if it can be removed. 

I've added a few test cases to test for the following:

- patches that are newly reviewed and singled are batched alone and not into existing waiting batches
- patches that are newly reviewed are not added to batches containing singled patches
- the bisecting process honors single patches

Co-authored-by: Kim Sae Hun <kimsaehun@csu.fullerton.edu>
Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Feb 26, 2020

@notriddle notriddle force-pushed the kimsaehun:205 branch from a569491 to 90ed18c Feb 26, 2020
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Feb 26, 2020

bors r+

Busted merge. Trying again.

bors bot added a commit that referenced this pull request Feb 26, 2020
Merge #839
839: Add a configuration option for batch size limiting r=notriddle a=kimsaehun

Fixes #205 

Took a while but I've implemented a 'r+ single on/off' command to have patches be batched by themselves only. However, this only occurs when patches are batched, either during bisect or when a patch is newly reviewed. I couldn't figure out how to make this apply for patches that are already in a running/waiting batch.

Additionally, I wasn't too sure whether ensuring that bisect honors the single patch option was a good idea or not. I'm thinking that it's unnecessary because if a batch fails, the singled patch will either become singled through enough bisections or will successfully merge into master without any issues. I implemented it just in case there was a case I have not thought of but please let me know if it can be removed. 

I've added a few test cases to test for the following:

- patches that are newly reviewed and singled are batched alone and not into existing waiting batches
- patches that are newly reviewed are not added to batches containing singled patches
- the bisecting process honors single patches

Co-authored-by: Kim Sae Hun <kimsaehun@csu.fullerton.edu>
Co-authored-by: Michael Howell <michael@notriddle.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Feb 26, 2020

@notriddle notriddle force-pushed the kimsaehun:205 branch from 90ed18c to 4093f31 Feb 26, 2020
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Feb 26, 2020

bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Feb 26, 2020

@bors bors bot merged commit c308cf1 into bors-ng:master Feb 26, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.