Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to prerun_timeout stuff #886

Merged
merged 5 commits into from Feb 23, 2020
Merged

Improvements to prerun_timeout stuff #886

merged 5 commits into from Feb 23, 2020

Conversation

@pksunkara
Copy link
Contributor

pksunkara commented Feb 22, 2020

Fixed the bug where bors is using the prerun_timout_sec not as the total time elapsed.

Also, removed the exponential backoff, since it get very big very soon. Changed the polling to a constant 5 mins.

@pksunkara pksunkara requested a review from notriddle Feb 22, 2020
@pksunkara pksunkara mentioned this pull request Feb 22, 2020
@notriddle

This comment has been minimized.

Copy link
Member

notriddle commented Feb 23, 2020

Function Github.map_changed_status/1 does not exist.

I think it should be GitHub.map_changed_status probably?

@pksunkara

This comment has been minimized.

Copy link
Contributor Author

pksunkara commented Feb 23, 2020

Oops. Fixed it 😄

Copy link
Member

notriddle left a comment

bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Feb 23, 2020

Build succeeded

@bors bors bot merged commit f9ef366 into bors-ng:master Feb 23, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
bors Build succeeded
Details
@pksunkara pksunkara deleted the pksunkara:improvements branch Feb 23, 2020
@pksunkara

This comment has been minimized.

Copy link
Contributor Author

pksunkara commented Feb 26, 2020

@notriddle I am not sure this actually fixed it. Check this PR. clap-rs/clap#1706. I approved before all the checks passed. But it's still not merging. Do you know what happened here? Can we try to find the logs?

notriddle added a commit to bors-ng/bors-ng.github.io that referenced this pull request Mar 2, 2020
Add @pksunkara as new contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.