Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Rename working branch for squash merge #933

Merged
merged 1 commit into from Apr 17, 2020

Conversation

francoisfreitag
Copy link
Contributor

The working branch used to create the squash merge commit should not be
tested by the CI system.
https://bors.tech/documentation/getting-started/ states:

Your CI system should build the “staging” and “trying” branches, but
should not build the “staging.tmp” and “trying.tmp” branches.

Suffixing with .tmp facilitate exclude by pattern: *.tmp.

The working branch used to create the squash merge commit should not be
tested by the CI system.
https://bors.tech/documentation/getting-started/ states:

> Your CI system should build the “staging” and “trying” branches, but
  should not build the “staging.tmp” and “trying.tmp” branches.

Suffixing with `.tmp` facilitate exclude by pattern: `*.tmp`.
Copy link
Member

@notriddle notriddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 17, 2020

@bors bors bot merged commit 61a25ba into bors-ng:master Apr 17, 2020
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Apr 17, 2020
Two hours ago, bors renamed the temporary branches. bors-ng/bors-ng#933  🙄
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
bors bot added a commit that referenced this pull request Aug 19, 2020
1005: Unique list of reviewers for multiple code changes #933 r=notriddle a=ucwaldo

This is a simple attempt to fix #993

While checking the `parse_owners.ex` file, i realized that it returns one reviewer per changed file even when all changes belong to the same codeowners.

To be honest, I did not dig very deep and it could be that this happens somewhere later in the pipeline already and i just missed it.

If that's the wrong approach because approvals are indeed tracked per file, i am happy to give it another go, ideally with some directions

Co-authored-by: Theo Fiedler <theodor.fiedler@xing.com>
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants