Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing null handling: #326

Closed
wants to merge 1 commit into from
Closed

Conversation

tolysz
Copy link
Contributor

@tolysz tolysz commented Dec 12, 2015

Simple solution; adding just one extra pattern match; almost by definition Null maps to Nothing in Maybe a situation and only the rest is exposed for further parsing.
resolves: #325

@phadej
Copy link
Collaborator

phadej commented Jan 14, 2016

#288 related

@tolysz
Copy link
Contributor Author

tolysz commented Jan 15, 2016

I re-based it.

@phadej
Copy link
Collaborator

phadej commented Jan 15, 2016

AFAICS #288 already fixed the issue?

@bergmark
Copy link
Collaborator

Right, I tested #325 and confirmed that this is fixed. Thank you for the pull request and sorry for not merging it.

@bergmark bergmark closed this Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse field some-string: expected Text, encountered Null
3 participants