2 bug fixes + new API function #3

Merged
merged 3 commits into from Jun 8, 2011

Conversation

Projects
None yet
3 participants
Contributor

batterseapower commented Jun 8, 2011

Pushed these as a group since I hope they will all be uncontroversial:

  1. Removed LLVMAddLoopIndexSplitPass, fixing bug #2. This pass was removed in the LLVM 2.9 release as "unmaintained buggy or a bad idea". This removes a public export and so is potentially a breaking change for users of the Haskell llvm library. I doubt that anyone will actually notice, though.
  2. Changed Setup.hs so it doesn't always add GlobalPackageDB to the package stack. Without this change, I was getting "Setup: internal error: unexpected package db stack: [GlobalPackageDB,GlobalPackageDB]" whenever Cabal tried to register the llvm package. The workaround was to supply --global on the command line. With my proposed change this is not necessary.
  3. Added liftCodeGenModule :: CodeGenModule a -> CodeGenFunction r a because some users of the library (such as mine) find it convenient to add to the containing Module while still in the middle of defining some Function. Working in the absence of this function can be difficult or involve big changes to client code that make it considerably less clear.

bos added a commit that referenced this pull request Jun 8, 2011

Merge pull request #3 from batterseapower/master
2 bug fixes + new API function

@bos bos merged commit 426b4e1 into bos:master Jun 8, 2011

Owner

bos commented Jun 8, 2011

Applied, thanks!

Collaborator

NathanHowell commented on 8709ecf Jun 24, 2011

This change causes an error on 7295141 building with:

cabal-install version 0.10.2
using version 1.10.1.0 of the Cabal library 

Installing library in /Users/nhowell/Library/Haskell/ghc-7.0.3/lib/llvm-0.9.1.3/lib
Registering llvm-0.9.1.3...
setup: internal error: unexpected package db stack: [UserPackageDB]

Backing the change out fixes the build.

Owner

bos replied Jun 24, 2011

Yes, I've noticed this problem too.

osa1 referenced this pull request in osa1/llvm Oct 4, 2012

Merge pull request #3 from osa1/new_wrappers
ExecutionEngine wrappers, some exports etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment