Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Read and Binary instances for ditributions does not check input validity #59

Open
Shimuuar opened this Issue · 0 comments

1 participant

@Shimuuar
Collaborator

Both Read and Binary instances for distributions are derived automatically. This leads to number of problems.

  • It allows to create distributions in invalid state. Smart constructors do check whether input valid or not. Derived methid will blindly decode what they get.

  • It breaks compatibility. Several distributions have fields which cache expensive computation. Their number and meaning could (and did!) change over time. Each such change breaks data format compatibility. They shouldn't be serialized in first place and recalculated during deserialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.