Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Windows build #264

Closed
1 task done
bpalaggi opened this issue Aug 23, 2019 · 5 comments
Closed
1 task done

Setup Windows build #264

bpalaggi opened this issue Aug 23, 2019 · 5 comments
Assignees
Labels
prio-high Story-Points:13 type-feature
Milestone

Comments

@bpalaggi
Copy link

@bpalaggi bpalaggi commented Aug 23, 2019

Setup a build process to have Agora compile and run tests on Windows (probably through Github actions). We should test at least DMD, and hopefully LDC as well.

DoD:

  • Agora is built and tested on Windows on each pull requests and push to v0.x.x
@Geod24 Geod24 added this to the 3. Flash Layer milestone Sep 4, 2019
@Geod24 Geod24 added the type-feature label Sep 4, 2019
@Geod24 Geod24 modified the milestones: 3. Flash Layer, 2. Validator Jan 21, 2020
@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Feb 25, 2020

So, more details about this:

  1. We should definitely use Github actions
  2. All the libraries we use are compatible with Windows, but most of the work will be on setting them up
  3. We can add it on PR only as a first step (https://github.com/bpfkorea/agora/blob/v0.x.x/.github/workflows/github_pr.yml)

@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Feb 25, 2020

Github actions documentation: https://help.github.com/en/actions
One of the issue you will face is that we use G++ to build our C++ code: https://github.com/bpfkorea/agora/blob/c7314c21700c526d6ee496090694bef46dc9da54/source/scpp/build.d#L51

@AndrejMitrovic
Copy link
Contributor

@AndrejMitrovic AndrejMitrovic commented Feb 25, 2020

Github might have a gcc compiler on Windows too (probably via MinGW). For example: https://github.com/onqtam/doctest/blob/875052e18cf5f5f0b9176e59f847b6205f3efb78/.github/workflows/main.yml#L46

@TrustHenry TrustHenry added the Story-Points:8 label Feb 26, 2020
@TrustHenry TrustHenry moved this from To do to In progress (Max 5) in Sprint #12 (2020-02-25 to 2020-03-9) Mar 2, 2020
@bpalaggi bpalaggi added this to To do in Sprint #13 (2020-03-10 to 2020-03-23) via automation Mar 10, 2020
@bpalaggi bpalaggi removed this from In progress (Max 5) in Sprint #12 (2020-02-25 to 2020-03-9) Mar 10, 2020
@bpalaggi bpalaggi moved this from To do to In progress (Max 5) in Sprint #13 (2020-03-10 to 2020-03-23) Mar 10, 2020
@bpalaggi bpalaggi added the prio-high label Mar 10, 2020
@bpalaggi bpalaggi added this to To do in Sprint #14 (2020-03-24 to 2020-04-6) via automation Mar 24, 2020
@bpalaggi bpalaggi removed this from In progress (Max 5) in Sprint #13 (2020-03-10 to 2020-03-23) Mar 24, 2020
@bpalaggi bpalaggi moved this from To do to In progress (Max 5) in Sprint #14 (2020-03-24 to 2020-04-6) Mar 24, 2020
@TrustHenry TrustHenry added Story-Points:13 and removed Story-Points:8 labels Mar 24, 2020
@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Apr 4, 2020

Done in #624

@Geod24 Geod24 closed this as completed Apr 4, 2020
Sprint #14 (2020-03-24 to 2020-04-6) automation moved this from In progress (Max 5) to Done Apr 4, 2020
@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Apr 4, 2020

Note: It is not tested on push currently, but that's a minor detail, and I will refactor the Github workflow so it is in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Story-Points:13 type-feature
Projects
No open projects
Development

No branches or pull requests

4 participants