Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node to node encryption #266

Closed
bpalaggi opened this issue Aug 23, 2019 · 3 comments · Fixed by #2208
Closed

Node to node encryption #266

bpalaggi opened this issue Aug 23, 2019 · 3 comments · Fixed by #2208
Assignees
Labels
C. Network Communication type-feature

Comments

@bpalaggi
Copy link

@bpalaggi bpalaggi commented Aug 23, 2019

As a user, I need all my node traffic to be sent encrypted in order to safeguard my privacy.

Currently, we have a single way to receive / exchange data: HTTP REST queries.
In the future, we want to move to a binary protocol, but should still be using SSL to transmit data.
Some method might still be exposed via REST and it should be over HTTPS.

@Geod24 Geod24 added this to the 5. CoinNet release milestone Sep 4, 2019
@Geod24 Geod24 added the type-feature label Sep 4, 2019
@Geod24 Geod24 added the C. Network Communication label Jul 5, 2020
@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Apr 8, 2021

Probably based on the validator's key and https://libsodium.gitbook.io/doc/key_exchange
See #1897

@bpalaggi bpalaggi removed this from the 5. CoinNet release milestone May 4, 2021
@Geod24 Geod24 added this to the 5. CoinNet release milestone Jun 1, 2021
@ferencdg
Copy link
Contributor

@ferencdg ferencdg commented Jun 9, 2021

would it be possible to have some of the enpoints configured as not encrypted? For example the crawler in #251 could be implemented in a much simpler/more efficient way if we had no encription on the FullNode.getNetworkInfo method. Also if we ever want to implement #1934, then encryptions would need to be optionally disabled.

@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Jun 9, 2021

It probably needs to be its own interface then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C. Network Communication type-feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants