Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Schnorr signature encoding according to SEC1 v2 (v2.3) #304

Closed
Geod24 opened this issue Sep 5, 2019 · 3 comments
Closed

Implement Schnorr signature encoding according to SEC1 v2 (v2.3) #304

Geod24 opened this issue Sep 5, 2019 · 3 comments
Assignees
Labels
C.Blockchain Story-Points:13 type-enhancement
Milestone

Comments

@Geod24
Copy link
Contributor

@Geod24 Geod24 commented Sep 5, 2019

See section v2.3 of this paper: https://www.secg.org/sec1-v2.pdf
This is not urgent, but required before we release publicly, as we're dependent on Libsodium's internal state at the moment.

Related to #208

@Geod24 Geod24 added the type-enhancement label Sep 5, 2019
@Geod24 Geod24 added this to the 5. CoinNet release milestone Sep 5, 2019
@Geod24 Geod24 added the C.Blockchain label Jul 5, 2020
@bpalaggi bpalaggi added the Story-Points:13 label Aug 12, 2020
@hewison-chris
Copy link
Member

@hewison-chris hewison-chris commented Aug 14, 2020

I spent some time researching the need to use a different encoding (SEC1 v2) for the signature as generated by the libsodium library. From what I can see the checks in the verify code are to prevent the malleability of the signature.

@hewison-chris
Copy link
Member

@hewison-chris hewison-chris commented Aug 20, 2020

In my opinion we should continue to use the libsodium 64 byte encoding of the Signature (R, s).

@Geod24
Copy link
Contributor Author

@Geod24 Geod24 commented Aug 20, 2020

Agreed. According to what @hewison-chris found, the points are already stored in canonical form.

@Geod24 Geod24 closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C.Blockchain Story-Points:13 type-enhancement
Projects
None yet
Development

No branches or pull requests

3 participants