Issue246 block reward - part 4 minus last commit to see if it still segv in tests on Mac in CI #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.x.x #2473 +/- ##
==========================================
+ Coverage 86.80% 86.95% +0.14%
==========================================
Files 154 153 -1
Lines 14948 14896 -52
==========================================
- Hits 12976 12953 -23
+ Misses 1972 1943 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is in preperation for when the payment block is no longer the same block as the last block paid for.
Fees are now only paid to Validators for blocks they sign. The `Coinbase` transaction is now included in the block at the end of the next payout period. The fees are the `sum of the inputs` minus the `sum of the outputs`. If we do not store the fees when we externalise a block then some inputs may be spent before the payout is made. The data fees are also stored as they are only paid to the 'Commons Budget' so are subtracted from the fees when paying the validators their percentage of fees.
Rewards should be calculated per block to enable payments to validators based on which have signed each block. The correct change can then also be calculated for the `Commons Budget`.
hewison-chris
force-pushed
the
issue246_block_reward_3B
branch
from
acabb16
to
a2dbf50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.