Create GossipProtocol #37
Conversation
This is not connected to the node.
In order to have it connected to the node, you need to add an API endpoint in the interface API (in agora.common.API then implement it on the server side agora.node.Node).
Then add a test in agora.test.Network
|
Side note: I'd recommend you squash your commits and rebase on top of v0.x.x: https://git-scm.com/book/ko/v2/Git-%EB%B8%8C%EB%9E%9C%EC%B9%98-Rebase-%ED%95%98%EA%B8%B0 |
|
The documentation mentions a "filter delegate" in code but I don't see it anywhere. Maybe the documentation needs to be updated? |
|
There are some styling inconsistencies, but I'm going to let @Geod24 decide on this because we still don't have a defined style guide (like https://dlang.org/dstyle.html). |
|
added getHasMessage of API |
|
@MukeunKim it is enough to comment only once that the pull request is updated. We will take a look. |
|
It looks good! I just made comments about small issues. |
Implement class GossipProtocol Add unittest for GossipProtocol
| /// Procedure of peer-to-peer communication | ||
| class GossipProtocol | ||
| { | ||
| private NetworkManager network; |
There was a problem hiding this comment.
Missing documentation for these two fields.
| { | ||
| return (msg in receivedMsgCache) !is null; | ||
| } | ||
|
|
Implement class GossipProtocol
Implement class Cache
Add unittest for GossipProtocol