Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RAM payer as eosio.forum & add `cancel` ACTION #56

Merged
merged 8 commits into from Jun 7, 2019

Conversation

Projects
3 participants
@DenisCarriere
Copy link
Collaborator

commented Jun 7, 2019

  • extend is used to extend the {{ expires_at }} timestamp value of a {{ proposal_name }} authorized by the {{ proposer }}.
  • cancel is used to cancel a {{ proposal_name }} authorized by the {{ proposer }}.
  • Set RAM payer as eosio.forum (_self) smart contract to all actions instead of users.

Testing

Deployed on BOS Testnet under eosforumdapp

https://bos-test.eosx.io/tools/contract?contractAccount=eosforumdapp

Test - RAM payer when voting

https://bos-test.eosx.io/tx/11881d71b42542738e8345f304683331eb32843e9d8a6c761a2ff45e1dc2fba5?listView=traces

Screen Shot 2019-06-06 at 8 54 54 PM

Test - extend proposal time as proposer

  • only authorized user
  • update proposal table data
  • cannot extend shorter timeline

https://bos-test.eosx.io/tx/f59b72335de82a71c0f663badda42854199fa347edd6f30f3828afed96244000?listView=traces

Test - cancel remove proposal & votes

  • removes proposal & vote from tables
  • removes votes before removing proposal
  • Enforce max_count to be high enough to prevent vote manipulation using the of cancel action

https://bos-test.eosx.io/tx/d9a3baedbc4a42ef7bdf3e9a708fd446583464e62fce0d2a8353e6767501e9d0?listView=traces

@DenisCarriere DenisCarriere requested review from kesar and removed request for kesar, Khazius, qianxiaofeng and Thaipanda Jun 7, 2019

@kesar

kesar approved these changes Jun 7, 2019

@libhasheos libhasheos merged commit 1053e0a into master Jun 7, 2019

@DenisCarriere DenisCarriere self-assigned this Jun 8, 2019

@DenisCarriere DenisCarriere added this to In progress in Contracts via automation Jun 8, 2019

@DenisCarriere DenisCarriere moved this from In progress to Done in Contracts Jun 8, 2019

@DenisCarriere DenisCarriere changed the title Add features to eosio.forum (extend/cancel/RAM payer) Set RAM payer as eosio.forum Jun 11, 2019

@DenisCarriere DenisCarriere changed the title Set RAM payer as eosio.forum Set RAM payer as eosio.forum & add `cancel` ACTION Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.